Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: additional-css UNIX style path normalization #162

Closed
wants to merge 0 commits into from

Conversation

carlocorradini
Copy link
Contributor

@carlocorradini carlocorradini commented Dec 13, 2023

Fix #161

I'm not sure if certain tests (Windows only) are necessary 🤔

@tommilligan
Copy link
Owner

This looks great, thanks for sending a fix as well. I think we should add a unit test and the Windows platform to CI, which I'll look at doing now. I can see I tried before and then disabled it for some reason, let's find out why!

@tommilligan
Copy link
Owner

tommilligan commented Dec 18, 2023

sigh - sorry, I forgot that github behaves weirdly if I try to push to a contributor's PR branch, when it is also the default branch in your fork. (looks to revert your branch, and close this PR automatically)

I've opened a clone of your fix here, with some additional changes on top to add a Windows test for it. Looks good!

If you would like to push the changes back into this PR so you get github kudos for it, please do, otherwise I'll merge that clone PR in a few days.

@tommilligan
Copy link
Owner

I have also added a note in the contributing guide #164 to remind myself of this behaviour in future

@carlocorradini
Copy link
Contributor Author

All good for me 🤗
Merge! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

additional-css UNIX style paths
2 participants