feat: remove console.log, change readme, package files, todos, test p…

…orts (#64)
tomek-f · May 9, 2023 · 833d54c · 833d54c
1 parent 945e310
commit 833d54c
Show file tree

Hide file tree

Showing 6 changed files with 21 additions and 20 deletions.
diff --git a/README.md b/README.md
@@ -2,10 +2,6 @@
 
 > Very simple promise based script loader and JSONP
 
-## Import
-
-[Check dist folder](https://www.npmjs.com/package/simple-load-script?activeTab=code) or package.json
-
 ## Usage
 
 ### Async/await
@@ -146,6 +142,10 @@ const defaultConfig = {
 - `insertInto` - [CSS selector (an ID, class name, element name, etc.)](https://developer.mozilla.org/en/docs/Web/API/Document/querySelector) to insert the script into. Overrides `inBody` value.
 - `removeScript` - remove script tag after load; it's always removed on an error
 
+## Specific import
+
+[Check files](https://www.npmjs.com/package/simple-load-script?activeTab=code) or package.json
+
 ## Changelog
 
 [View on github](https://github.com/tomek-f/simple-load-script/blob/master/changelog.md).

diff --git a/package.json b/package.json
@@ -23,7 +23,9 @@
     "check-types": "echo 'checking types…' && tsc && echo '…no type problems'"
   },
   "files": [
-    "dist"
+    "src",
+    "dist",
+    "changelog.md"
   ],
   "main": "./dist/index.umd.js",
   "umd:main": "./dist/index.umd.js",

diff --git a/src/index.ts b/src/index.ts
@@ -58,8 +58,6 @@ export default function simpleLoadScript(
       }
     }
 
-    console.log({ config, configProcessed });
-
     if (where == null) {
       reject(new Error('No DOM element to append script'));
       return;
@@ -71,11 +69,12 @@ export default function simpleLoadScript(
       }
       resolve(removeScript ? undefined : script);
     });
-    script.addEventListener('error', (err) => {
-      console.log(err);
+    script.addEventListener('error', (/* err */) => {
       if (removeScript) {
         where.removeChild(script);
       }
+      // TODO ? just return err
+      // TODO ? re-throw err with changed message
       reject(new Error('Loading script error'));
     });
     script.src = url;

diff --git a/test/attrs.spec.ts b/test/attrs.spec.ts
@@ -10,7 +10,7 @@ let page: Page;
 
 beforeAll(async () => {
   browser = await chromium.launch({ headless: true });
-  server = await preview({ preview: { port: 3000 } });
+  server = await preview({ preview: { port: 3001 } });
   page = await browser.newPage();
 });
 
@@ -25,7 +25,7 @@ test(
   'add attrs',
   async () => {
     try {
-      await page.goto('http://localhost:3000');
+      await page.goto('http://localhost:3001');
       await page.evaluate(async () => {
         await window.simpleLoadScript({
           url: '//code.jquery.com/jquery-2.2.3.js',
@@ -52,7 +52,7 @@ test(
   'dom not add attrs',
   async () => {
     try {
-      await page.goto('http://localhost:3000');
+      await page.goto('http://localhost:3001');
       await page.evaluate(async () => {
         await window.simpleLoadScript({
           url: '//code.jquery.com/jquery-2.2.3.js',

diff --git a/test/placement.spec.ts b/test/placement.spec.ts
@@ -10,7 +10,7 @@ let page: Page;
 
 beforeAll(async () => {
   browser = await chromium.launch({ headless: true });
-  server = await preview({ preview: { port: 3000 } });
+  server = await preview({ preview: { port: 3003 } });
   page = await browser.newPage();
 });
 
@@ -25,7 +25,7 @@ test(
   'placement head',
   async () => {
     try {
-      await page.goto('http://localhost:3000');
+      await page.goto('http://localhost:3003');
       await page.evaluate(async () => {
         await window.simpleLoadScript({
           url: '//code.jquery.com/jquery-2.2.3.js',
@@ -46,7 +46,7 @@ test(
   'placement body',
   async () => {
     try {
-      await page.goto('http://localhost:3000');
+      await page.goto('http://localhost:3003');
       await page.evaluate(async () => {
         await window.simpleLoadScript({
           url: '//code.jquery.com/jquery-2.2.3.js',
@@ -68,7 +68,7 @@ test(
   'insertInto ok',
   async () => {
     try {
-      await page.goto('http://localhost:3000');
+      await page.goto('http://localhost:3003');
       await page.evaluate(async () => {
         await window.simpleLoadScript({
           url: '//code.jquery.com/jquery-2.2.3.js',
@@ -90,7 +90,7 @@ test(
   'insertInto error',
   async () => {
     try {
-      await page.goto('http://localhost:3000');
+      await page.goto('http://localhost:3003');
       await page.evaluate(async () => {
         await window.simpleLoadScript({
           url: '//code.jquery.com/jquery-2.2.3.js',

diff --git a/test/removeScript.spec.ts b/test/removeScript.spec.ts
@@ -10,7 +10,7 @@ let page: Page;
 
 beforeAll(async () => {
   browser = await chromium.launch({ headless: true });
-  server = await preview({ preview: { port: 3000 } });
+  server = await preview({ preview: { port: 3004 } });
   page = await browser.newPage();
 });
 
@@ -25,7 +25,7 @@ test(
   'removeScript true',
   async () => {
     try {
-      await page.goto('http://localhost:3000');
+      await page.goto('http://localhost:3004');
       await page.evaluate(async () => {
         await window.simpleLoadScript({
           url: '//code.jquery.com/jquery-2.2.3.js',
@@ -52,7 +52,7 @@ test(
   'removeScript false',
   async () => {
     try {
-      await page.goto('http://localhost:3000');
+      await page.goto('http://localhost:3004');
       await page.evaluate(async () => {
         await window.simpleLoadScript({
           url: '//code.jquery.com/jquery-2.2.3.js',