Merge branch 'master' into api-e2e-tests

tomcarter23 · Dec 4, 2024 · c1b469c · c1b469c
2 parents 6a2cfc7 + 6aae231
commit c1b469c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/adversarial_attack/fgsm.py b/adversarial_attack/fgsm.py
@@ -54,10 +54,14 @@ def standard_attack(
         orig_pred = model(tensor)
 
     if orig_pred.argmax().item() != truth.item():
-        raise ValueError(
-            f"Model prediction {orig_pred.argmax().item()} does not match true class {truth.item()}.",
-            f"It is therefore pointless to perform an attack.",
+        warnings.warn(
+            (
+                f"Model prediction {orig_pred.argmax().item()} does not match true class {truth.item()}."
+                f"It is therefore pointless to perform an attack."
+            ),
+            RuntimeWarning,
         )
+        return None
 
     # make a copy of the input tensor
     adv_tensor = tensor.clone().detach()

diff --git a/tests/unit/test_fgsm.py b/tests/unit/test_fgsm.py
@@ -70,8 +70,8 @@ def test_standard_attack_failure(model):
     epsilon = 0.1
     max_iter = 50
 
-    with pytest.raises(ValueError, match="does not match true class"):
-        standard_attack(model=model, tensor=tensor, truth=truth, epsilon=epsilon, max_iter=max_iter)
+    with pytest.warns(RuntimeWarning):
+        assert standard_attack(model=model, tensor=tensor, truth=truth, epsilon=epsilon, max_iter=max_iter) is None
 
 
 def test_standard_attack_no_change(model):