Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backports modifications made by Sunblink. #5

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

justonia
Copy link

Changes:

  • Routines, when stopped explicitly, now throw a RoutineStoppedException so that the async method can do cleanup in a try/catch/finally
  • Use of DEBUG changed to DEBUG_ROUTINES, so that dev builds don't do expensive logging.
  • Call stack compression via HideInCallstack attribute, so stack traces on routines aren't massive in logs.
  • Support for no-domain-reload enter playmode option by resetting statics correctly.

Unfortunately, some files show full changes due to space/tabs/win/mac file formatting stuff. And some files have bad indentation for the same reason. I'd suggest that we just run the entire repo source through a formatter to make it consistent.

* Routines, when stopped explicitly, now throw a RoutineStoppedException so that
  the async method can do cleanup in a try/catch/finally
* Use of DEBUG changed to DEBUG_ROUTINES, so that dev builds don't do expensive
  logging.
* Call stack compression via HideInCallstack attribute, so stack traces on routines
  aren't massive in logs.
* Support for no-domain-reload enter playmode option by resetting statics correctly.
@tomblind
Copy link
Owner

Can we fix the formatting in the pr before merging?

@justonia
Copy link
Author

justonia commented Apr 1, 2024

@tomblind Sure, wanted to check first with you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants