Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add Indonesian translations #31

Merged
merged 1 commit into from
Oct 27, 2024
Merged

Conversation

daviddprtma
Copy link
Contributor

@daviddprtma daviddprtma commented Oct 27, 2024

Iam adding the indonesian translations to make developer who using laravel filament can choose Bahasa Indonesia translation.

Summary by CodeRabbit

  • New Features

    • Added support for the Indonesian language in the application.
    • Introduced localization strings for various UI elements and timestamps in Indonesian.
    • Enhanced language selector to include Indonesian.
  • Documentation

    • New files created for Indonesian translations, providing a comprehensive set of localization strings.

Copy link

coderabbitai bot commented Oct 27, 2024

Walkthrough

The changes in this pull request enhance the localization capabilities of the application by adding support for the Indonesian language. A new entry for Indonesian has been added to the locals array in the config/filament-translations.php file. Additionally, two new PHP files, global.php and translation.php, have been created in the resources/lang/id/ directory, providing localization strings and translations for various user interface elements.

Changes

File Path Change Summary
config/filament-translations.php Added entry for Indonesian language: 'id' => ['label' => 'Indonesia', 'flag' => 'id']
resources/lang/id/global.php New file created with localization strings for Indonesian: includes keys for 'created_at', 'updated_at', etc.
resources/lang/id/translation.php New file created with translations for UI elements in Indonesian, including titles, labels, notifications, and actions.

Poem

🐰 In the land where the rice fields sway,
A new tongue joins the play,
With labels bright and phrases sweet,
Indonesian now makes our app complete!
Hops of joy, a language to share,
Together we grow, with love and care! 🌾


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between c664781 and 888cefa.

📒 Files selected for processing (3)
  • config/filament-translations.php (1 hunks)
  • resources/lang/id/global.php (1 hunks)
  • resources/lang/id/translation.php (1 hunks)
✅ Files skipped from review due to trivial changes (2)
  • resources/lang/id/global.php
  • resources/lang/id/translation.php
🔇 Additional comments (1)
config/filament-translations.php (1)

54-57: LGTM! The Indonesian language configuration is correctly implemented.

The addition follows the proper format and uses correct ISO codes:

  • Language code 'id' follows ISO 639-1
  • Country code 'id' follows ISO 3166-1 alpha-2
  • Label is appropriately set to "Indonesia"

Let's verify the existence of the corresponding language files:

✅ Verification successful

Indonesian language configuration and required files are properly set up

The verification confirms that both required language files exist in the correct location:

  • resources/lang/id/global.php
  • resources/lang/id/translation.php
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify that the required Indonesian language files exist
# Expected: Should find global.php and translation.php in the Indonesian language directory

# Check for Indonesian language files
fd -e php . "resources/lang/id"

Length of output: 94


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@3x1io 3x1io merged commit bf2db99 into tomatophp:master Oct 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants