Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dependency to hermit-abi #1830

Merged
merged 1 commit into from
Sep 28, 2024
Merged

Conversation

stlankes
Copy link
Contributor

  • use directly libc as platform interface

@stlankes
Copy link
Contributor Author

Ok, we have to wait for the missing error numbers. see rust-lang/libc#3858

@stlankes stlankes marked this pull request as draft August 19, 2024 19:24
- use directly libc as platform interface
@stlankes stlankes marked this pull request as ready for review September 28, 2024 14:29
@stlankes
Copy link
Contributor Author

A new version of libc is published and the dependency to hermit-abi can be removed. But I don't understand that CI / Sanitizer (leak) failed. Does someone have an idea? I just use a new version of libc.

@Thomasdezeeuw
Copy link
Collaborator

@stlankes the CI can be ignored it's a sanitizer issue, Mio is not to blame.

@Thomasdezeeuw Thomasdezeeuw merged commit 8b6c4b5 into tokio-rs:master Sep 28, 2024
59 of 60 checks passed
@Thomasdezeeuw
Copy link
Collaborator

Thanks @stlankes

@stlankes
Copy link
Contributor Author

@Thomasdezeeuw Do you know, when you publish a new release? I would prefer to remove this dependency from the latest release.

@Thomasdezeeuw
Copy link
Collaborator

I'll prepare a release now. I don't really have a schedule for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants