Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Wasm example instructions #1780

Closed
wants to merge 1 commit into from
Closed

Conversation

FrankReh
Copy link

@FrankReh FrankReh commented May 2, 2024

With these two new versions of the lines that state how to build the Wasm module and then how to run it with wasmtime, the Wasm demo of an mio TcpListener again works.

Note this crate still uses the wasi 0.11.0 dependency. The 0.12.0 and most recent 0.13.0 versions are built on a new WASI paradigm given the name WASI Preview 2, or WASI 0.2 for short. Those are likely going to require a lot more work again.

I'm just guessing the build will require the wasm32-wasip2 target but the std library doesn't build with that target yet, so this is just a small intermediate step.

Also worth noting is the recommended build step has been changed. Now +nightly is not needed and in fact causes the build to fail due to clippy warnings being treated as errors.

@fakeshadow
Copy link

wasm32-wasi target is facing deprecation so it's better to switch to other targets like wasm32-wasip1 or wasm32-wasip1-threads in example comment.

@Thomasdezeeuw
Copy link
Collaborator

We should rethink our wasm preview 1 & 2 strategy and update his example accordingly. Closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants