Run the MSRV CI check on more platforms #1710
Conversation
Since we have fairly complex dependencies now I think it's best to run the check on more platforms. Backport of commit 2856112.
|
This will need #1711 as well. |
|
@Thomasdezeeuw this will need the ntapi fix as well |
This might be fixed in #1707, I'm not exactly sure if that is a breaking change or not. |
According to rust-lang/rust#105167 and rust-lang/rust#107252 (comment), Xcode 14 broke support for rustc < 1.53. Backport of commit 8dd37c5.
|
What kind of breakage are you worried about? |
Not exactly sure at the moment want we expose of Miow in our public API and the second worry is the MSRV. I just recall something about not being able to update Miow/ntapi in Mio v0.7... except I don't remember the details anymore. But I could be completely wrong here. |
|
You can use https://github.com/awslabs/cargo-check-external-types to check which external types are visible in mio's api. As for the MSRV, no Tokio LTS uses mio v0.7, so it's completely fine with me if you want to bump the MSRV of mio v0.7. I'm not sure what MSRV policy mio has? |
Mio doesn't really have a properly defined MSRV policy, but it would be odd if v0.7 only supported a newer rustc version than v0.8. But for v1 we need to away with MSRV and just say we support x time period of rustc versions, e.g. the last year or so. |
Since we have fairly complex dependencies now I think it's best to run the check on more platforms.
Backport of #1709, commit 2856112.