Fix Clippy warnings #1696
Fix Clippy warnings #1696
Conversation
Matching what we use to test v0.8.
This matches v0.8 CI.
For various combination of the feature we can sometimes end up with TcpKeepalive's fields not being used. Since we know that they are used with other features the simplest solution is to just ignore the list for now.
Never added it to the Makefile.
Some files are not picked up by running cargo fmt, but find src tests examples -type f -iname "*.rs" | xargs rustfmt does the trick.
|
The Windows CI is failing due to MSxDOS/ntapi#19, but I don't if the upgrade to ntapi v0.4 is a breaking change, in v0.8 we don't depend on ntapi. |
|
Is any of its types in the public api of mio anywhere? |
I don't think so, it's being pulled in via Miow, I don't think we use it directly anywhere. But since v0.7 doesn't compile with rustc v1.67 (?) on Windows... I don't think a lot people are using v0.7 any more. I'm not sure if it's worth putting much more time into it. |
|
It sounds like its probably not a breaking change. |
I think we need to update to Miow v0.4/v0.5, both already use windows-sys. I personally don't have the time to do this, so I'm going to merge this as-is, since it doesn't further break the code, but now we at least have a working CI for v0.7 again. |
These changes are already in master/v0.8.