Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add special handling of Extension and Clone for debug_handler #2301

Closed

Conversation

loganbnielsen
Copy link
Contributor

Motivation

Addresses #2294 using the solution discussed there. (Link)

@loganbnielsen
Copy link
Contributor Author

Am I supposed to do anything to request a review?

@jplatte
Copy link
Member

jplatte commented Nov 22, 2023

No. I can request David's review and maybe also take a look myself (though given that this is mostly stuff that David wrote, I don't want to merge w/o his review), but I don't think it will actually speed up things as there's probably a bandwidth problem, not an awareness problem.

@jplatte jplatte requested a review from davidpdrsn November 22, 2023 21:49
@loganbnielsen
Copy link
Contributor Author

No problem, just wanted to make sure I wasn't dropping the ball

@jplatte jplatte requested review from jplatte and removed request for davidpdrsn March 13, 2024 23:25
Copy link
Collaborator

@yanns yanns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can have a good value when someone is using Extension.

@jplatte
Copy link
Member

jplatte commented May 6, 2024

I couldn't see why we would need to special case Extension in particular when we already make sure to have good error messages for other extractors such as Json so I decided to see what the error message is on main with #[debug_handler]. Turns out that we don't actually need to do anything, see #2731.

@jplatte jplatte closed this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants