Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow for disabling crossbeam-channel #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: allow for disabling crossbeam-channel #33

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,15 @@ exclude = ["data"]
resolver = "2"

[features]
default = ["recovery", "log-trace"]
default = ["recovery", "log-trace", "crossbeam-channel"]
recovery = ["sysinfo"]
log-trace = [] # test only
log-debug = [] # test only
crossbeam-channel = ["notify/default"]
no-crossbeam-channel = ["notify/macos_kqueue"]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, what has made me a bit uneasy was this: every time we compile for a MacOS target we would have to use this no-crossbeam-feature? Could we use [target.'cfg(target_os = "macos")'.dependencies] instead? (I have googled and it says this is a bit broken, but at least worth a shot. Else, could we use. cfg in the code directly?)

Copy link
Author

@raphaelcoeffic raphaelcoeffic Feb 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about that at first, and it did work as well, but I believe it is actually related to using the tokio runtime rather than macOS. I did not test this under Linux though to confirm if this really the case.

The reason why it is needed to require kqueue is because notify does not provide a default for macOS if you don't use the default feature.


[dependencies]
notify = "5.1.0"
notify = { version = "5.1.0", default-features = false }
log = "0.4.17"
sysinfo = { version = "0.28.0", default-features = false, optional = true }
futures = "0.3.26"
Expand Down