Skip to content

Commit

Permalink
Release version 0.4.1
Browse files Browse the repository at this point in the history
Return from method if content block is null
Update nuget packages
Add .ConfigureAwait(false)
  • Loading branch information
nurhafiz committed Oct 11, 2023
1 parent a3e771f commit cbfc81b
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="Toimik.WarcProtocol" Version="0.2.4" />
<PackageReference Include="Toimik.WarcProtocol" Version="0.9.0" />
</ItemGroup>

<ItemGroup>
Expand Down
8 changes: 4 additions & 4 deletions src/Toimik.CommonCrawl/Toimik.CommonCrawl.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
<TargetFramework>net6.0</TargetFramework>
<Nullable>enable</Nullable>
<AssemblyName>Toimik.CommonCrawl</AssemblyName>
<PackageVersion>0.4.0</PackageVersion>
<PackageVersion>0.4.1</PackageVersion>
<Authors>Nurhafiz</Authors>
<Version>0.4.0</Version>
<Version>0.4.1</Version>
<PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
<Company>Toimik</Company>
<Description>
Expand All @@ -29,8 +29,8 @@
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="System.Linq.Async" Version="6.0.1" />
<PackageReference Include="System.Text.Json" Version="7.0.1" />
<PackageReference Include="Toimik.WarcProtocol" Version="0.2.4" />
<PackageReference Include="System.Text.Json" Version="7.0.3" />
<PackageReference Include="Toimik.WarcProtocol" Version="0.9.0" />
</ItemGroup>

</Project>
5 changes: 5 additions & 0 deletions src/Toimik.CommonCrawl/Wat/WarcParserWatUrlExtractor.cs
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,11 @@ protected override IEnumerable<string> ExtractUrls(Streamer<Record>.Result resul
{
var metadataRecord = (MetadataRecord)record;
var contentBlock = metadataRecord.ContentBlock;
if (contentBlock == null)
{
yield break;
}

JsonDocument document;
try
{
Expand Down
12 changes: 6 additions & 6 deletions tests/Toimik.CommonCrawl.Tests/Toimik.CommonCrawl.Tests.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -7,23 +7,23 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="coverlet.msbuild" Version="3.2.0">
<PackageReference Include="coverlet.msbuild" Version="6.0.0">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.4.1" />
<PackageReference Include="Moq" Version="4.18.3" />
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.7.2" />
<PackageReference Include="Moq" Version="4.20.69" />
<PackageReference Include="StyleCop.Analyzers" Version="1.1.118">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="System.Linq.Async" Version="6.0.1" />
<PackageReference Include="xunit" Version="2.4.2" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.4.5">
<PackageReference Include="xunit" Version="2.5.1" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.5.1">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="coverlet.collector" Version="3.2.0">
<PackageReference Include="coverlet.collector" Version="6.0.0">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
Expand Down
2 changes: 1 addition & 1 deletion tests/Toimik.CommonCrawl.Tests/WarcParserStreamerTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,7 @@ await Assert.ThrowsAsync<ArgumentException>(
await streamer.Stream(
hostname: "www.example.com",
urlSegmentList: "/foobar",
urlSegmentOffset: 3).ToListAsync().ConfigureAwait(false));
urlSegmentOffset: 3).ToListAsync().ConfigureAwait(false)).ConfigureAwait(false);

Check warning on line 237 in tests/Toimik.CommonCrawl.Tests/WarcParserStreamerTest.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest)

Test methods should not call ConfigureAwait(), as it may bypass parallelization limits. (https://xunit.net/xunit.analyzers/rules/xUnit1030)
}

[Fact]
Expand Down

0 comments on commit cbfc81b

Please sign in to comment.