Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mobile): replace search with create in app tab #8934

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from

Conversation

CatsJuice
Copy link
Member

@CatsJuice CatsJuice commented Nov 27, 2024

  • Remove search on AppTab, replaced with create doc
  • Always show AppTab for editor page
  • Extract NavigationBack from PageHeader

Copy link

graphite-app bot commented Nov 27, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

nx-cloud bot commented Nov 27, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e93edb9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@CatsJuice CatsJuice marked this pull request as ready for review November 27, 2024 02:43
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.84%. Comparing base (31c806e) to head (e93edb9).
Report is 10 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #8934      +/-   ##
==========================================
- Coverage   70.53%   64.84%   -5.70%     
==========================================
  Files         544      659     +115     
  Lines       33741    37311    +3570     
  Branches     3005     3596     +591     
==========================================
+ Hits        23799    24193     +394     
- Misses       9579    12750    +3171     
- Partials      363      368       +5     
Flag Coverage Δ
server-test 77.07% <ø> (-0.01%) ⬇️
unittest 35.01% <ø> (-11.75%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant