Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): support team workspace subscription #8919

Open
wants to merge 1 commit into
base: 61/refactor-payment-service
Choose a base branch
from

Conversation

forehalo
Copy link
Member

@forehalo forehalo commented Nov 25, 2024

close AF-1724, AF-1722

Copy link

graphite-app bot commented Nov 25, 2024

Your org has enabled the Graphite merge queue for merging into canary

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

forehalo commented Nov 25, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 67.05202% with 228 lines in your changes missing coverage. Please review.

Project coverage is 65.76%. Comparing base (0b92962) to head (05a054c).

Files with missing lines Patch % Lines
...nd/server/src/plugins/payment/manager/workspace.ts 57.14% 81 Missing ⚠️
...ges/backend/server/src/plugins/payment/resolver.ts 39.02% 50 Missing ⚠️
...ages/backend/server/src/plugins/payment/service.ts 69.78% 42 Missing ⚠️
...ckend/server/src/plugins/payment/manager/common.ts 75.96% 25 Missing ⚠️
...ges/backend/server/src/plugins/payment/schedule.ts 21.87% 25 Missing ⚠️
...ackend/server/src/fundamentals/error/errors.gen.ts 80.95% 4 Missing ⚠️
...backend/server/src/plugins/payment/manager/user.ts 98.21% 1 Missing ⚠️
Additional details and impacted files
@@                       Coverage Diff                       @@
##           61/refactor-payment-service    #8919      +/-   ##
===============================================================
+ Coverage                        65.58%   65.76%   +0.17%     
===============================================================
  Files                              669      671       +2     
  Lines                            37686    38222     +536     
  Branches                          3644     3671      +27     
===============================================================
+ Hits                             24716    25136     +420     
- Misses                           12622    12738     +116     
  Partials                           348      348              
Flag Coverage Δ
server-test 78.06% <67.05%> (-0.04%) ⬇️
unittest 34.79% <ø> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

nx-cloud bot commented Nov 25, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 05a054c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@forehalo forehalo force-pushed the 61/team-workspace-subscription branch from baeab09 to 4e6b606 Compare November 25, 2024 12:35
@forehalo forehalo force-pushed the 61/team-workspace-subscription branch from 4e6b606 to 3267873 Compare November 26, 2024 03:32
@forehalo forehalo force-pushed the 61/team-workspace-subscription branch from 3267873 to dc22bfe Compare November 26, 2024 08:43
@forehalo forehalo force-pushed the 61/team-workspace-subscription branch from dc22bfe to 5fdae93 Compare November 26, 2024 09:12
@forehalo forehalo force-pushed the 61/team-workspace-subscription branch from 5fdae93 to 1db5184 Compare November 26, 2024 09:22
Copy link
Member Author

@forehalo forehalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should reuse subscriptions table

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:server test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant