Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FE] 카드 수정 기능 #35

Merged
merged 2 commits into from
Jul 19, 2023
Merged

[FE] 카드 수정 기능 #35

merged 2 commits into from
Jul 19, 2023

Conversation

hjsong333
Copy link

의도

카드 수정을 위한 과정 및 수정 동작 구현

구체적으로 봐야하는 포인트, 세부적인 변경점

  • Column.tsx 의 editCard
  • 수정 후 전체 목록 요청
  • App 전체에 CardForm을 1개만 유지하기 위한 로직을 Board.tsx에 추가함

관련 이슈

hjsong333 added 2 commits July 19, 2023 04:46
@hjsong333
feat: 카드 수정 동작 구현
2d8942f 
- 병합된 구조에 카드 수정 동작 연결
- 카드 등록과 수정 폼을 전체에서 1개만 유지하는 로직 추가
- id가 동일한 별개의 카드가 수정되는 현상 관측됨
@hjsong333
chore: mock 데이터 수정
9ba8e69 
- 카드 id가 겹치지 않게 변경
@hjsong333 hjsong333 added ✨feat New feature or request 💻FE labels Jul 19, 2023
@hjsong333 hjsong333 requested a review from saejinpark July 19, 2023 02:58
@hjsong333 hjsong333 self-assigned this Jul 19, 2023
saejinpark
saejinpark reviewed Jul 19, 2023
View reviewed changes
Copy link

@saejinpark saejinpark left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다 좋은것 같습니다.

@hjsong333 hjsong333 merged commit 1a63c92 into frontend Jul 19, 2023
@hjsong333 hjsong333 deleted the fe/feature/card-edit branch July 19, 2023 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saejinpark saejinpark saejinpark left review comments

Assignees

@hjsong333 hjsong333

Labels
💻FE ✨feat New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hjsong333 @saejinpark