[FE] 공통 컴포넌트 구현 #31
Merged
[FE] 공통 컴포넌트 구현 #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjsong333
reviewed
Jul 18, 2023
Comment on lines
+5
to
+22
| const Header = styled(({ className }: { className?: string }) => { | ||
| return ( | ||
| <header className={className}> | ||
| <h1 className="blind">헤더</h1> | ||
| <a className="logo" href="/"> | ||
| TODO LIST | ||
| </a> | ||
| <Buttons | ||
| $Flexible="" | ||
| $Type="Ghost" | ||
| $ElementPattern="Icon Only" | ||
| $States="Enable" | ||
| icon="History" | ||
| onClick={() => console.log("기록 열기")} | ||
| /> | ||
| </header> | ||
| ); | ||
| })<{ theme: TTheme }>` |
There was a problem hiding this comment.
const function HaederComponent({ className }: { className?: string }) => {
return (
<header className={className}>
<h1 className="blind">헤더</h1>
<a className="logo" href="/">
TODO LIST
</a>
<Buttons
$Flexible=""
$Type="Ghost"
$ElementPattern="Icon Only"
$States="Enable"
icon="History"
onClick={() => console.log("기록 열기")}
/>
</header>
);
}
const Header = styled(HeaderComponent)`
`
이런 식이 가독성이 더 나아보입니다. 어떠신가요?
| <h3 className={className}> | ||
| <span className="text-aria"> | ||
| <span className="title">{title}</span> | ||
| <Badge $2DigitPlus={count > 99} digit={count} /> |
There was a problem hiding this comment.
2DigitPlus는 Badge가 알아서 판단해도 괜찮을 것 같습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FE] 공통 컴포넌트 구현
의도
프로젝트에서 전반적으로 사용되는 공통 컴포넌트 개발
구체적으로 봐야하는 포인트, 세부적인 변경점
관련 이슈