Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OSPO Book] add preface and chapter one draft for review #282
[OSPO Book] add preface and chapter one draft for review #282
Changes from 24 commits
a060b8e
b628374
82b11b8
979e3f4
4bd2cbb
56266d5
8fe07ff
969a85b
015dc87
d182d61
4cb0a81
8ea3d27
802f9bb
82cfd08
b13a6eb
267c30d
fe42490
4058307
b523f4b
c0b57c1
c4ab43c
9c35d9d
2fd5963
815e357
6775a95
052cb0a
b49b894
09229e4
88c753a
4bfc710
f9fd905
b48285d
5261c7e
5af27ff
4785545
c23f403
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would delete this one, as it is implicitly covered in the first sentence. Articulating it like this might get confusing, since we indicated above that we'll not cover contributions to open source projects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In those three paragraphs, there are too many
,
andand
. I could understand well because I know what each section means. But other people like beginners may struggle with understanding each description.What about making the list with bullet points, or providing a picture such as a mindmap?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not entire sure if the terminology of "OSPO (as center of expertise)" and "OSPO (as a role)" is not overly complicated and not really needed. It creates the impression as if the abbreviation "OSPO" can apply to multiple different things. Wouldn't it be more straightforward to just use the terms as follows (on a high level):
Just a proposal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section reads a little confusing to me as well. It also doesn't read as a definition, but it rather talks about what the org does, in some extent, and what responsibilities it has.
I would focus on really just defining here what the term actually means. I would establish that it is a group of people with the goals of X, Y and Z.
Then we can have subsections that talk about the OSPO's responsibilities, structure, job roles within that org and even suggest where it might sit within a bigger organization to be able to make impact.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
During yesterday's call, we agreed to come up with a different word to define the "different hats" that people within an OSPO play. The "persona" term was discussed but is also highly related to marketing definition and might create confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[From Contirbutor's call discussion] two differentiations might unblock this: OSPO as the entity and the people behind an OSPO (that includes roles, skillsets, etc)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a little confusing to me. Is the goal here to use these terms/roles below later in the book?
To me the actions that the roles cover read more as responsibilities of an OSPO. However, as it is currently structured, it looks a little bit like we're hinting a bit to create these roles within the org.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed in a meeting and the idea of "persona" was brought to light, although it may mean something different in marketing circles.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any valid case where creating an OSPO could be a starting point? Or one of the starting points?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and the below paragraph refer to 'open source adoption' and 'open source software adoption' without defining what these actually mean.
In this section I would rather be more practical and say that a companies and organizations need to assess their current goals and relationship with using and collaborating to open source software projects. And that below we're providing a framework and a checklist to assess and better understand their current stage and next steps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still have a hard time with using the OSPO term for both an entity as well as a group of roles. I think it is very easy to associate to job roles and functions, rather than the responsibilities that we listed above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should store the images in tree and also the editable versions of the images.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1! I can prepare an /img folder with the images and fix the links accordingly 👍