Upgrade the project to .net 8.0 and fix high security vulnerabilities (one failing test remaining) #548
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I wanted to fix a dependency that is rated a high-security vulnerability, but in order to do that I had to make significant upgrades to the project, such as upgrading it to .net 8.0. I hope you're ok with that, if not, we can discuss.
There is 1 test that's failing but I think the test is incorrectly written. I can fix it we agree on a solution
a) test shouldn't throw an exception if you pass a valid string but the file doesn't exist
b) test should throw a filenotfound exception or something like that if the string exists but the file path doesn't
c) other ?