Add syscall_scope, a scope guard for system calls.
#342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`syscall_scope` creates a scope in which Allow and Subscribe system calls can be soundly executed, by guaranteeing that the buffers and upcalls are revoked before their lifetime ends. The exact system calls (type and ID) are inferred from the type of the closure passed to `syscall_scope`, using the `ShareList` trait. `syscall_scope` is the `run` function described at tock#341, and `ShareList` is the `SyscallList` trait.
jrvanwhy
added
the
significant
|
Ping on reviews? This blocks further work on the Allow and Subscribe syscall APIs. |
hudson-ayers
approved these changes
Nov 12, 2021
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 16, 2021
342: Add `syscall_scope`, a scope guard for system calls. r=jrvanwhy a=jrvanwhy `syscall_scope` creates a scope in which Allow and Subscribe system calls can be soundly executed, by guaranteeing that the buffers and upcalls are revoked before their lifetime ends. The exact system calls (type and ID) are inferred from the type of the closure passed to `syscall_scope`, using the `ShareList` trait. `syscall_scope` is the `run` function described at #341, and `ShareList` is the `SyscallList` trait. Co-authored-by: Johnathan Van Why <[email protected]>
|
Build failed: |
|
CI failed because |
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
syscall_scopecreates a scope in which Allow and Subscribe system calls can be soundly executed, by guaranteeing that the buffers and upcalls are revoked before their lifetime ends. The exact system calls (type and ID) are inferred from the type of the closure passed tosyscall_scope, using theShareListtrait.syscall_scopeis therunfunction described at #341, andShareListis theSyscallListtrait.