-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: performance improvement by lazy python #4613
base: main
Are you sure you want to change the base?
Conversation
While this makes the tokenizer much quicker, I think it would be good to benchmark slightly higher level to make sure we aren't seeing the slow down in other calls upstream. |
can you run the regular benchmarks? |
0825a93
to
1e8ece5
Compare
Struggling when running
Will have to be something for tomorrow. |
1e8ece5
to
4efe27f
Compare
- make comments and texts getters
4efe27f
to
1f9e2ec
Compare
|
||
#[getter(token_type)] | ||
fn token_type(&self, py: Python) -> PyObject { | ||
match &self.token_type { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this optional?
e7fd582
to
b98ff12
Compare
b98ff12
to
d7b2c17
Compare
extract_string
of when to compute things