Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding functionality to ignore SQL Server version check #33

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

NullReferenceError
Copy link

Basically I just catch the exception and throw it out if the flag is enabled. Works for my use case, there might be a better way to do it. Let me know if there are any changes you want.

@anton-kirschhock
Copy link
Contributor

The issue I have is that you've hardcoded the exception string. I suspect that this will not work on, for example, on dutch servers,....
Also I find it odd that the api interface is throwing errors but the SSRS UI not. It is, to me, more an infra issue

@NullReferenceError
Copy link
Author

I agree that catching that specific error message isn't the best method, but we don't want to throw out all SOAP Exceptions (That error message comes from the System.Web.Services.Protocols.SoapException namespace) maybe I can find a more specific code in the exception to handle.

2018-03-21T21:51:44.7466933Z ##[error]Microsoft.PowerShell.Commands.WriteErrorException: System.Web.Services.Protocols.SoapException: The definition of this report is not valid or supported by this version of Reporting Services. The report definition may have been created with a later version of Reporting Services, or contain content that is not well-formed or not valid based on Reporting Services schemas. Details: '.', hexadecimal value 0x00, is an invalid character. Line 1, position 1. 2018-03-21T21:51:44.7466933Z at Microsoft.ReportingServices.Library.ReportingService2010Impl.CreateReport(String Report, String Parent, Boolean Overwrite, Byte[] Definition, Property[] Properties, ItemType ItemType, CatalogItem& ItemInfo, Warning[]& Warnings) 2018-03-21T21:51:44.7466933Z at Microsoft.ReportingServices.Library.ReportingService2010Impl.CreateCatalogItem(String ItemType, String Name, String Parent, Boolean Overwrite, Byte[] Definition, Property[] Properties, CatalogItem& ItemInfo, Warning[]& Warnings) 2018-03-21T21:51:44.7476933Z at Microsoft.ReportingServices.WebServer.ReportingService2010.CreateCatalogItem(String ItemType, String Name, String Parent, Boolean Overwrite, Byte[] Definition, Property[] Properties, CatalogItem& ItemInfo, Warning[]& Warnings)

ALSO! I did find that this specific message happens when other file types that are not .rdl or .rds make it into the /bin/ folder of a report build from visual studio, and the extension tries to upload the entire directory if the filetype is not specified. Maybe a filter can just be applied for those filetypes as the input to prevent this? I do see that the extension supports wildcards, so checking that user's use "/.rdl" instead of "/" can typically prevent the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants