[WIP] RolePlay prompts and behavioural improvements #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way we will make a clear separation between input and expected output for the model. Based on my tests Clause models struggle to read complex rules without that and treat input chunks as examples of changes. In addition to that lang prompt moved to a system one. metada removed as it wan't used anywhere.
Commit message commonly answer on question why the change was made and will help in reducing pointless suggestions from LLM which already taken into account. Overall prompt restrucutred according to Anthropic style guide (bulletpoints and heading via MD).
kuzaxak
changed the title
```
{
"line_start": 103,
"line_end": 104,
"comment": "Similar to the previous comment, the formatting improvement here is good for consistency and readability."
}
],
"lgtm": true
```
Bedrock models respond with useless comments confirming that all good with lgtm set to `true`.
```
"reviews": [
{
"line_start": 30,
"line_end": 30,
"comment": "The `image_tag_mutability` attribute is set to a boolean value (`true`), but it should be a string value of either 'MUTABLE' or 'IMMUTABLE'. Consider updating this line to:\n\n```diff\n- image_tag_mutability = try(each.value[\"image_tag_mutability\"], true)\n+ image_tag_mutability = try(each.value[\"image_tag_mutability\"], \"MUTABLE\")\n```\n\nThis change ensures that the default value is 'MUTABLE', which aligns with AWS's default behavior and maintains backward compatibility as mentioned in the commit message."
}
],
"lgtm": false
}
```
In case of actual comment `lgtm` set to `false`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check commits for details. Overall the goal to prevent model to add commits like:
Which aren't helpful.