Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

Concurrent SSo #4

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Concurrent SSo #4

wants to merge 6 commits into from

Conversation

janat08
Copy link

@janat08 janat08 commented Jun 14, 2017

Modifies accounts method to try and handle several users.

I couldn't connect how OAuth interacts with Accounts completely to avoid modifying base accounts method, which I suspect OAuth won't understand- as I haven't tried this at all. I don't know how to make packages or understand OAuth, so I decided to let you see this first before trying to debug this.

I removed Accounts.oauth.registerService(...), as I suppose that it is intended to provide indexes on id field. The id field changed to char id, since I provide list of char name and ids in a separate array to let user to index query by char id, and there's upper field size limit with indexes to which end I opted for more convenient/shorter field name (although multikey indexes may behave differently in this regard).

I'm not eager to understand OAuth to implement character owner change detection in refresh token helper (as to avoid providing access to original owner), that SSO doesn't enforce: https://www.reddit.com/r/Eve/comments/5ymo4l/psa_if_youve_purchased_a_character_clear_your/#bottom-comments.

Approximate accounts logic that I undug, and important variables that appear to interface with meteor from AOuth. If you'd like to consider how to implement this logic elsewhere.

  • Origin 1394 (updateorCreateUserFromExternalService) makes/updates user record
  • Consumes origin command with listener for SSO package invocation, controller for auth to interface with accounts
  • Search for consumption of event listener (login auth), or login event on accounts/auth obj)
  • /........................../ unkown bridge
  • //should be handleOauthRequest param that invokes...
  • Registration of service with availabe data makes an object(.registerService(handleOauthRequest)

janat08 added 6 commits June 14, 2017 22:58
Modifies accounts method to try and handle several users.
typo
Modifies accounts method to try and handle several users.
typo

typo
readme
@janat08
Copy link
Author

janat08 commented Jun 17, 2017

Crashes likely because I imported accounts-base wrong as it points to accounts.js file and errors "Error: ENOENT: no such file or directory, open '/home/jk/Documents/garlic/packages/janat08:multiple-accounts-eveonline/lib/accouts.js'"

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant