Move new-lines displayed for the ctrl+c message to default constant
#323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kiancross
approved these changes
Dec 29, 2023
kiancross
changed the title
ctrl+c message to default constant
…be manually printed
Electro707
force-pushed
the
pr/kbi_msg_nl
branch
from
115b2d2 to
ab284b5
Compare
|
I have re-pushed my changes, but I it seems the workflow still needs an approval? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem that this PR addresses?
This modules, when the user presses CTRL-C, will print a new-line before and after the message "Cancelled by user ". For some applications, these new-lines might not be desirable.
How did you solve it?
Removed the printing of new-lines when the KBI message is printed, and instead moved the new-lines to the default message, un-effecting default operation.
Checklist