Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MKPC pulls #7

Open
wants to merge 14 commits into
base: development
Choose a base branch
from
Open

MKPC pulls #7

wants to merge 14 commits into from

Conversation

Gapva
Copy link
Contributor

@Gapva Gapva commented Feb 13, 2022

Fixed very few grammatical errors within the course builder and in other places

tmalahie and others added 7 commits January 30, 2022 18:21
"You use" --> "You're using"
"Face off" --> "Face-off"
"cpu" --> "CPU"
Added support for 90hz (mobile) devices, 144hz and 240hz monitors. fixed a typo where the "r" in "frame" was missing in "interframe"
@Gapva Gapva changed the title Fixed more grammatical errors MKPC pulls Feb 19, 2022
Added button hover animations and some additional design to them as well; added Tiny and Massive (translated both languages, checked with Fways), fixed very few capitalization errors
Edited pause hotkey script and pause function (incase of touchscreen) to make this work :)
Copy link
Owner

@tmalahie tmalahie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are great suggestions, but I think we can improve it before going to production

@@ -3870,6 +3872,7 @@ var fLineScale = 0;
// setup main container
var oContainers = [document.createElement("div")];
oContainers[0].className = "game-container";
oContainers[0].id = "game-container"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need this id, oContainers[0] is already the same as document.getElementById("game-container")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought so, just felt like we needed an id but that also works :)

scripts/mk.js Outdated Show resolved Hide resolved
scripts/mk.js Outdated Show resolved Hide resolved
scripts/mk.js Outdated Show resolved Hide resolved
styles/mariokart.css Show resolved Hide resolved
Gapva and others added 3 commits February 21, 2022 20:33
Co-authored-by: Malahieude Timothé <[email protected]>
Co-authored-by: Malahieude Timothé <[email protected]>
Co-authored-by: Malahieude Timothé <[email protected]>
"CHANGE RACE" --> "CHANGE TRACK";
There are no issues with the French translation, so I did not tamper with it.
@tmalahie tmalahie force-pushed the development branch 2 times, most recently from fb8de0a to 62a8ef4 Compare February 4, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants