Use Python threading to avoid creating temp files #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
making asitop not need to write file on the filesystem Signed-off-by: Zhang Zongyu <[email protected]>
Signed-off-by: zongyu <[email protected]>
since temp files do not exists anymore, the memory consumption problem no longer exists. Signed-off-by: zongyu <[email protected]>
|
Seems nice, I'll try to check if the memory issue had been resolved. |
After 6 hours, the python process memory was still only around 30MB, memory issue has gone. |
Signed-off-by: Zhang Zongyu <[email protected]>
Waiting for the queue to be filled by utils.enqueue_powermetrics() implies that we need to sleep for args.interval seconds, so we do not need extra lines to sleep between `powermetrcis` outputs. Signed-off-by: Zhang Zongyu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an effort to avoid creating temp files under
/tmpfolder.It uses Python's threading and queueing library to receive and preprocess the output of
powermetrics.The main change is presented in commit 1daf3ad
The other 2 commits are for code cleanups.
The whole process is described as follows:
powermetricsis configured to output tostdoutenqueue_powermetrics(), which willstdoutinto separate plists (by the magicb'\x00'character)parse_powermetrics()will get the latest plist from the LIFO queue, and parse the plist as usualThis PR will hopefully resolve issues #18, #17 and #35.
Also #6 may also be resolved (without restarting
powermetricsmultiple times).