Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default cloud storage key #438

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Update default cloud storage key #438

merged 2 commits into from
Dec 6, 2024

Conversation

zkharit
Copy link
Contributor

@zkharit zkharit commented Dec 6, 2024

Summary & Motivation

Telegram Cloud storage does not allow for the @ or / signs in cloud storage keys, so change the default key to conform to those standards.

How I Tested These Changes

Did you add a changeset?

If updating one of our packages, you'll likely need to add a changeset to your PR. To do so, run pnpm changeset. pnpm changeset will generate a file where you should write a human friendly message about the changes. Note how this (example) includes the package name (should be auto added by the command) along with the type of semver change (major.minor.patch) (which you should set).

These changes will be used at release time to determine what packages to publish and how to bump their version. For more context see this comment.

@zkharit zkharit requested a review from r-n-o December 6, 2024 19:41
Copy link

codesandbox-ci bot commented Dec 6, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

@r-n-o r-n-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need a changeset entry for this (patch release I think since you're fixing a bug?)

@moe-dev
Copy link
Contributor

moe-dev commented Dec 6, 2024

You'll need a changeset entry for this (patch release I think since you're fixing a bug?)

+1 - patch release required here, changelog can be in a separate PR or in this one (a bit cleaner)

@zkharit
Copy link
Contributor Author

zkharit commented Dec 6, 2024

Forgot the changeset 😅, added to this PR

@zkharit zkharit merged commit cefc9eb into main Dec 6, 2024
5 checks passed
@zkharit zkharit deleted the zane/update-storage-key branch December 6, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants