Re-introduce VERSION
in @turnkey/http
#191
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This re-introduces the changes from #186 and #187 after they were reverted in #190.
I'm very, very disappointed in Changesets, a tool we're using for releases.
npm
itself has plenty of lifecycle hooks to handle custom scripts pre and post version (see this). But these lifecycle hooks aren't called bychangeset version
! Wut. People are complaining about this...changeset version
changesets/changesets#1166...but no responses from the maintainers.
I tried instrumenting
preversion
,prepublish
,version
, etc...nothing seems to work becausechangeset
doesn't call any of these. In the end I settled for a custom "version" script. This has the advantage to be explicit but it's one more script to call during releases. The problem: what if we forget to call it when we publish new versions? For this I've got a CI check which should catch any oversight.How I Tested These Changes
Did you add a changeset?
Yes! ✅