Upgrade to node v18 #184
Merged
Upgrade to node v18 #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
andrewkmin
reviewed
Dec 13, 2023
thanks for adding this clarity |
r-n-o
force-pushed
the
rno/upgrade-to-node18
branch
from
6bb9ad3 to
eb8f13d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Node 16 has been deprecated since September. Time to upgrade! This PR addresses #120. Because node v18 comes with its own experimental fetch API our code which tried to mock
fetchwas failing. I've opted to always use cross-fetch regardless of whetherfetchis available inglobalThisbecause cross-fetch is meant to be used for exactly this reason! It detects when native implementations are available and uses either browser or node fetch when they're available.Having
fetchin a known location is nice because we have a seam to mock it.How I Tested These Changes
Unit tests
Did you add a changeset?
Changeset added and packages bumped!