Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add change set instructions to PR template #164

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Add change set instructions to PR template #164

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac9922e
Add changeset instructions to PR template
emostov Nov 16, 2023
1469afc
Arnaud's feedback
emostov Nov 17, 2023
a45f738
Update changes
emostov Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## Summary & Motivation

## How I Tested These Changes

## Did you update the changeset?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: should be "Did you add a changeset?"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a45f738


You should add file to describe the change from this pr that looks like `.changeset/<changename>.md` ([example](https://github.com/tkhq/sdk/blob/b409cd06790f011bf939adcf0755499b8e7497ae/.changeset/extra-http-exports.md?plain=1#L1)). Note that at the top it includes the package name along with the type of [semver change (major.minor.patch).](https://semver.org/). These changes will be used at release time to determine what packages to publish and how to bump their version. For more context see [this comment](https://github.com/tkhq/sdk/pull/67#issuecomment-1568838440).
emostov marked this conversation as resolved.
Show resolved Hide resolved
Loading