ethers v5 --> v6 #131
ethers v5 --> v6 #131
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
andrewkmin
force-pushed
the
andrew/ethers-v6
branch
from
5cbdce8 to
bb9a513
Compare
There was a problem hiding this comment.
v6 reads much better than v5 👏
Do you want to have a changeset here? I think you'll need to release a major version bump for @turnkey/ethers, and then see which packages depend on it. Might be good to spot check the examples using ethers but looks like you've done this already!
packages/ethers/src/index.ts
Outdated
| @@ -1,10 +1,10 @@ | |||
| import { ethers } from "ethers"; | |||
| import { TurnkeyActivityError, TurnkeyRequestError } from "@turnkey/http"; | |||
| import type { TurnkeyClient } from "@turnkey/http"; | |||
| import type { TypedDataSigner } from "@ethersproject/abstract-signer"; | |||
| // import type { TypedDataSigner } from "@ethersproject/abstract-signer"; | |||
packages/ethers/src/index.ts
Outdated
| // maybe we no longer need to drop this | ||
| // delete unsignedTx.from; |
There was a problem hiding this comment.
Can you explain your reasoning? Generally, when it doubt: ✂️ -- we can always add this back later if needed.
There was a problem hiding this comment.
I believe ethers v6 now has native support for eip1193 (no Eip1193Bridge required). However, I'm not sure this is currently unit testable in this way (node environment). I've reached out to the Ethers team to see if there is a new, Ethers v6-specific way of creating an eip1193 provider.
If they don't come up with a solution in a timely manner or say it's currently not supported, I'm also down to remove this test for now and revisit this topic altogether once we upgrade demo-consumer-wallet as a whole
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
andrewkmin
force-pushed
the
andrew/ethers-v6
branch
2 times, most recently
from
b4f2db1 to
88f8785
Compare
andrewkmin
force-pushed
the
andrew/ethers-v6
branch
from
949cd02 to
c90cc07
Compare
andrewkmin
force-pushed
the
andrew/ethers-v6
branch
from
c90cc07 to
a3fe099
Compare
|
closing in favor of #200 |
Summary & Motivation
$title! The upgrade isn't quite complete until we have an Eip1193Bridge for Ethers v6. This is on the Ethers teams' radar; for now, if that's a crucial piece of functionality for our users, they can resort to using our Ethers v5 implementation.
How I Tested These Changes