DRAFT: @turnkey/native-passkey-stamper package
#122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Michael Perhats <[email protected]>
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
r-n-o
commented
Sep 25, 2023
There was a problem hiding this comment.
I'm not sure but I think these files shouldn't be checked in right? commonjs, module, typescript files are all compiled from the main ts files I believe.
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
r-n-o
force-pushed
the
rno/native-passkey-stamper
branch
from
9bb6722 to
4fe68d4
Compare
|
See #209 for a new approach leveraging an existing OSS library for the tricky (native) parts! Closing this PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Pulling the react native stamper developed by @Mperhats in this PR; there's probably more work to do to integrate it with CI + release a minimal example using it, but I think it's useful to have this up here for inspection!
TODOs