ethers ❤️ passkeys #113
Merged
ethers ❤️ passkeys #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
andrewkmin
force-pushed
the
andrew/ethers-passkeys
branch
from
2994be9 to
42ab764
Compare
MaxBlaushild
reviewed
Sep 8, 2023
| let response = activityResponse.data as TActivityResponse; | ||
| let attempts = 0; | ||
|
|
||
| while (attempts < 3) { |
There was a problem hiding this comment.
Can we not use the poller here?
MaxBlaushild
approved these changes
Sep 8, 2023
andrewkmin
force-pushed
the
andrew/ethers-passkeys
branch
from
42ab764 to
228f173
Compare
andrewkmin
force-pushed
the
andrew/ethers-passkeys
branch
from
3aa3ee1 to
cde1a5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Ushering in our Turnkey Ethers signer to the new, fancy world full of purpose-driven stampers!
How I Tested These Changes
e2e, unit, smoke