Skip to content

Commit

Permalink
feedback: breaking change
Browse files Browse the repository at this point in the history
  • Loading branch information
andrewkmin committed Oct 19, 2023
1 parent dca8c91 commit b3d31ef
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 10 deletions.
2 changes: 1 addition & 1 deletion packages/cosmjs/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
### Patch Changes

- Updated dependencies
- @turnkey/http@1.4.0
- @turnkey/http@2.0.0
- Updated the shape of signing

## 0.4.9
Expand Down
2 changes: 1 addition & 1 deletion packages/ethers/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
### Patch Changes

- Updated dependencies
- @turnkey/http@1.4.0
- @turnkey/http@2.0.0
- Updated the shape of signing

## 0.17.2
Expand Down
14 changes: 8 additions & 6 deletions packages/http/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@
# @turnkey/http

## 1.4.0
## 2.0.0

### Minor Changes
### Major Changes

- Synced protos from mono
- Consolidated signing routes:
- We now have a single route, `/api/v1/submit/sign_raw_payload` for `SignRawPayload` activities (previously this was split into `SignRawPayload` and `SignRawPayloadV2`)
- This extends to `/api/v1/submit/sign_transaction` as well. `SignTransaction` and `SignTransactionV2` now have a unified activity: `SignTransaction`
- Under the hood, these routes stay largely the same: you can sign raw payloads and transactions with an address (from a wallet account), or a private key ID

### Upgrade notes

- `signRawPayload` and `signTransaction` now expect a `signWith` param instead of `privateKeyId` previously
- `signRawPayload` and `signTransaction` have been updated to expect a new type: `ACTIVITY_TYPE_SIGN_RAW_PAYLOAD_V2` and `ACTIVITY_TYPE_SIGN_TRANSACTION_V2`, respectively
- If you have policies authorizing `ACTIVITY_TYPE_SIGN_RAW_PAYLOAD` or `ACTIVITY_TYPE_SIGN_TRANSACTION` specifically, they will need to be updated to authorize `ACTIVITY_TYPE_SIGN_RAW_PAYLOAD_V2` and `ACTIVITY_TYPE_SIGN_TRANSACTION_V2` (or better yet, update your policies to allow all signing actions categorically using policy resources and actions. See https://docs.turnkey.com/managing-policies/examples)

## 1.3.0

Expand Down
2 changes: 1 addition & 1 deletion packages/http/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@turnkey/http",
"version": "1.4.0",
"version": "2.0.0",
"main": "./dist/index.js",
"types": "./dist/index.d.ts",
"license": "Apache-2.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/viem/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
- 59dcd2f: Unpin typescript
- da7c960: Bump Viem dependency to fix `getAddresses()` for LocalAccount
- Updated dependencies
- @turnkey/http@1.4.0
- @turnkey/http@2.0.0
- Updated the shape of signing

## 0.2.5
Expand Down

0 comments on commit b3d31ef

Please sign in to comment.