fix: remove module side effects

tkhq · Nov 27, 2023 · 2b9c5a7 · 2b9c5a7
1 parent 66e8707
commit 2b9c5a7
Show file tree

Hide file tree

Showing 8 changed files with 9 additions and 15 deletions.
diff --git a/packages/api-key-stamper/package.json b/packages/api-key-stamper/package.json
@@ -44,7 +44,6 @@
     "prepublishOnly": "pnpm -w run clean-all && pnpm -w run build-all",
     "build": "rollup -c",
     "clean": "rimraf ./dist ./.cache",
-    "pack": "npm pack && mv *.tgz /Users/jessecollier/git/test-app-1/",
     "test": "jest",
     "typecheck": "tsc -p tsconfig.typecheck.json"
   },

diff --git a/packages/api-key-stamper/src/index.ts b/packages/api-key-stamper/src/index.ts
@@ -13,18 +13,19 @@ export type TApiKeyStamperConfig = {
 /**
  * Signature function abstracting the differences between NodeJS and web environments for signing with API keys.
  */
-let signWithApiKey: (input: {
+export const signWithApiKey = async (input: {
   content: string;
   publicKey: string;
   privateKey: string;
-}) => string;
-
-if (typeof globalThis?.crypto?.subtle !== "undefined") {
-  signWithApiKey = require("./webcrypto").signWithApiKey;
-} else {
-  signWithApiKey = require("./nodecrypto").signWithApiKey;
+}): Promise<string> => {
+  if (typeof globalThis?.crypto?.subtle !== "undefined") {
+    const fn = await import("./webcrypto").then((m) => m.signWithApiKey);
+    return fn(input);
+  } else {
+    const fn = await import("./nodecrypto").then((m) => m.signWithApiKey);
+    return fn(input);
+  }
 }
-export { signWithApiKey };
 
 /**
  * Stamper to use with `@turnkey/http`'s `TurnkeyClient`

diff --git a/packages/cosmjs/package.json b/packages/cosmjs/package.json
@@ -43,7 +43,6 @@
     "prepublishOnly": "pnpm -w run clean-all && pnpm -w run build-all",
     "build": "rollup -c",
     "clean": "rimraf ./dist ./.cache",
-    "pack": "npm pack && mv *.tgz /Users/jessecollier/git/test-app-1/",
     "test": "jest --passWithNoTests",
     "typecheck": "tsc -p tsconfig.typecheck.json"
   },

diff --git a/packages/ethers/package.json b/packages/ethers/package.json
@@ -43,7 +43,6 @@
     "prepublishOnly": "pnpm -w run clean-all && pnpm -w run build-all",
     "build": "rollup -c",
     "clean": "rimraf ./dist ./.cache",
-    "pack": "npm pack && mv *.tgz /Users/jessecollier/git/test-app-1/",
     "compile:contracts": "hardhat compile",
     "test": "jest",
     "typecheck": "tsc -p tsconfig.typecheck.json"

diff --git a/packages/http/package.json b/packages/http/package.json
@@ -41,7 +41,6 @@
     "prepublishOnly": "pnpm -w run clean-all && pnpm -w run build-all",
     "build": "rollup -c",
     "clean": "rimraf ./dist ./.cache",
-    "pack": "npm pack && mv *.tgz /Users/jessecollier/git/test-app-1/",
     "test": "jest",
     "typecheck": "tsc -p tsconfig.typecheck.json"
   },

diff --git a/packages/iframe-stamper/package.json b/packages/iframe-stamper/package.json
@@ -43,7 +43,6 @@
     "prepublishOnly": "pnpm -w run clean-all && pnpm -w run build-all",
     "build": "rollup -c",
     "clean": "rimraf ./dist ./.cache",
-    "pack": "npm pack && mv *.tgz /Users/jessecollier/git/test-app-1/",
     "test": "jest",
     "typecheck": "tsc -p tsconfig.typecheck.json"
   },

diff --git a/packages/viem/package.json b/packages/viem/package.json
@@ -46,7 +46,6 @@
     "prepublishOnly": "pnpm -w run clean-all && pnpm -w run build-all",
     "build": "rollup -c",
     "clean": "rimraf ./dist ./.cache",
-    "pack": "npm pack && mv *.tgz /Users/jessecollier/git/test-app-1/",
     "test": "jest",
     "anvil": "anvil",
     "typecheck": "tsc -p tsconfig.typecheck.json",

diff --git a/packages/webauthn-stamper/package.json b/packages/webauthn-stamper/package.json
@@ -43,7 +43,6 @@
     "prepublishOnly": "pnpm -w run clean-all && pnpm -w run build-all",
     "build": "rollup -c",
     "clean": "rimraf ./dist ./.cache",
-    "pack": "npm pack && mv *.tgz /Users/jessecollier/git/test-app-1/",
     "test": "jest",
     "typecheck": "tsc -p tsconfig.typecheck.json"
   },