Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CODEOWNERS file to include dependency-reviewers group #496

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Update CODEOWNERS file to include dependency-reviewers group #496

merged 1 commit into from
Nov 26, 2024

Conversation

r-n-o
Copy link
Contributor

@r-n-o r-n-o commented Nov 25, 2024

Summary & Motivation (Problem vs. Solution)

Adds an extra layer of notification when Cargo.toml or Cargo.lock files change. We'll want to carefully review these updates when they happen.

@r-n-o r-n-o requested a review from a team as a code owner November 25, 2024 23:38
@cr-tk
Copy link
Collaborator

cr-tk commented Nov 26, 2024

As the person who proposed this change internally, I think it makes sense and is ready to merge.

We'll need a qos-operator team member to formally approve this.

@r-n-o r-n-o merged commit 01ef347 into main Nov 26, 2024
6 checks passed
@r-n-o r-n-o deleted the rno/codeowners-update branch November 26, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moe-dev moe-dev moe-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@r-n-o @cr-tk @moe-dev