-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Rust (1.76->1.81) + fix Makefile and lints #492
Conversation
b09f3c6
to
dd54694
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me -- I think we should pair this up with a PR to mono that bumps the equivalent StageX packages
@jack-kearney this is already done actually: I've aligned versions with what's in our mono containerfile. (another way to think about this PR is we're catching up to mono for Rust and other stagex packages) |
Calling out a couple differences here:
Don't have a ton of context on where these hashes came from but would like to chat through the differences |
Writing down what we uncovered looking into this:
The latest diff aligns with mono on all shas, including the ones I missed. This is out of an abundance of caution: as noted before, the version of these dependencies aren't used in actual enclave builds: mono is authoritative anyway! This alignment is good to avoid drift and catch build-time problems early. |
Summary & Motivation (Problem vs. Solution)
This branch contains a bunch of chore-style QOL improvements:
Makefile
call intosrc/Makefile
targets instead of defining its own recipe. The drift is causing major inconsistencies.+nightly
toolchain. Yes the extra lints are nice, but they're not worth inconsistencies between stagex and local linting jobs. Going forward we're only using one version of Rust for everything: 1.81 stable ✅ (as the nightly lint rules move into stable rustfmt, we can re-enable them if we still like them)make shell
to work correctly on MacOS (whereenv
's-C
option doesn't exist!)src/integration/src/bin/gen_att_doc.rs
which was failing lints and was not compiling (using non-existent APIs). It's been "dead" code for a long time because of themock
feature. It's not defined inqos_integration
, hence the code is never compiled.How I Tested These Changes
CI