Add enclave encrypt package and use go 1.21 #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviathet
force-pushed
the
olivia/enclave-encrypt
branch
from
cde2ffb to
0f31ad7
Compare
oliviathet
changed the title
oliviathet
changed the title
oliviathet
changed the base branch from
olivia/update-swagger-v2024.2.2
to
main
timurnkey
approved these changes
Mar 11, 2024
| @@ -33,7 +33,7 @@ func Test_FromTkPrivateKey(t *testing.T) { | |||
| // NIST CURVE: P-256 | |||
| privateKeyFromOpenSSL := "487f361ddfd73440e707f4daa6775b376859e8a3c9f29b3bb694a12927c0213c" | |||
| apiKey, err := apikey.FromTurnkeyPrivateKey(privateKeyFromOpenSSL) | |||
| assert.Nil(t, err) | |||
| require.NoError(t, err) | |||
There was a problem hiding this comment.
omg we've needed this so bad for e2e tests
| } | ||
|
|
||
| // Decrypt a message from the server. | ||
| func (c *EnclaveEncryptClient) AuthDecrypt(payload string) (plaintext []byte, err error) { |
There was a problem hiding this comment.
What's the difference between Decrypt and AuthDecrypt? Could you update the comment to explain when one is used vs the other? They both currently show:
// Decrypt a message from the server.
| ) | ||
|
|
||
| // An instance of the client side for enclave encrypt protocol. This should only be used for either | ||
| // a SINGLE send or a single receive. |
There was a problem hiding this comment.
we could "enforce" this by setting a private boolean value when it has been "used", but that doesn't necessarily prevent misuse 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enclave_encryptpackage from monorepo to be used by tk cli (Import private keys and wallets + replace toolchain with stagex tkcli#54, Export private keys and wallets tkcli#55).enclave_encryptpackage uses