Linting fixes

client.go

@@ -30,6 +30,7 @@ type OptionFunc func(c *config) error
 func WithClientVersion(clientVersion string) OptionFunc {
 	return func(c *config) error {
 		c.clientVersion = clientVersion
+
 		return nil
 	}
 }
@@ -38,6 +39,7 @@ func WithClientVersion(clientVersion string) OptionFunc {
 func WithRegistry(registry strfmt.Registry) OptionFunc {
 	return func(c *config) error {
 		c.registry = registry
+
 		return nil
 	}
 }
@@ -46,6 +48,7 @@ func WithRegistry(registry strfmt.Registry) OptionFunc {
 func WithTransportConfig(transportConfig client.TransportConfig) OptionFunc {
 	return func(c *config) error {
 		c.transportConfig = &transportConfig
+
 		return nil
 	}
 }
@@ -56,6 +59,7 @@ func WithTransportConfig(transportConfig client.TransportConfig) OptionFunc {
 func WithAPIKey(apiKey *apikey.Key) OptionFunc {
 	return func(c *config) error {
 		c.apiKey = apiKey
+
 		return nil
 	}
 }
@@ -68,7 +72,9 @@ func WithAPIKeyName(keyname string) OptionFunc {
 		if err != nil {
 			return errors.Wrap(err, "failed to load API key")
 		}
+
 		c.apiKey = apiKey
+
 		return nil
 	}
 }
@@ -81,7 +87,10 @@ func New(options ...OptionFunc) (*Client, error) {
 	}
 
 	for _, o := range options {
-		o(c)
+		err := o(c)
+		if err != nil {
+			return nil, err
+		}
 	}
 
 	// Create transport and client
@@ -115,12 +124,13 @@ type addClientVersion struct {
 
 func (acv *addClientVersion) RoundTrip(r *http.Request) (*http.Response, error) {
 	r.Header.Set("X-Client-Version", acv.Version)
+
 	return acv.inner.RoundTrip(r)
 }
 
 // NewHTTPClient returns a new base HTTP API client.
 // Most users will call New() instead.
-// Deprecated: Use New(WithRegistry(formats)) instead
+// Deprecated: Use New(WithRegistry(formats)) instead.
 func NewHTTPClient(formats strfmt.Registry) *client.TurnkeyAPI {
 	return client.NewHTTPClient(formats)
 }

examples/signing/sign_transaction/main.go

@@ -13,7 +13,7 @@ import (
 )
 
 func main() {
-	// NB: make sure to create and register an API key,first.
+	// NB: make sure to create and register an API key, first.
 	client, err := sdk.New(sdk.WithAPIKeyName("default"))
 	if err != nil {
 		log.Fatal("failed to create new SDK client:", err)

examples/wallets/create_wallet/main.go

@@ -13,7 +13,7 @@ import (
 )
 
 func main() {
-	// NB: make sure to create WithAPIKeyand register an API key, first.
+	// NB: make sure to create and register an API key, first.
 	client, err := sdk.New(sdk.WithAPIKeyName("default"))
 	if err != nil {
 		log.Fatal("failed to create new SDK client:", err)

pkg/apikey/apikey.go

@@ -50,11 +50,11 @@ type APIStamp struct {
 // New generates a new Turnkey API key.
 func New(organizationID string, opts ...optionFunc) (*Key, error) {
 	if organizationID == "" {
-		return nil, fmt.Errorf("please supply a valid Organization UUID")
+		return nil, errors.New("please supply a valid Organization UUID")
 	}
 
 	if _, err := uuid.Parse(organizationID); err != nil {
-		return nil, fmt.Errorf("failed to parse organization ID")
+		return nil, errors.New("failed to parse organization ID")
 	}
 
 	apiKey := &Key{

pkg/apikey/ecdsa.go

@@ -29,6 +29,10 @@ func (k *ecdsaKey) sign(msg []byte) (string, error) {
 	return hex.EncodeToString(sigBytes), nil
 }
 
+// TurnkeyECDSAPublicKeyBytes is the expected number of bytes for a public ECDSA
+// key.
+const TurnkeyECDSAPublicKeyBytes = 33
+
 // EncodePrivateECDSAKey encodes an ECDSA private key into the Turnkey format.
 // For now, "Turnkey format" = raw DER form.
 func EncodePrivateECDSAKey(privateKey *ecdsa.PrivateKey) string {
@@ -81,7 +85,7 @@ func DecodeTurnkeyPublicECDSAKey(encodedPublicKey string, scheme signatureScheme
 		return nil, err
 	}
 
-	if len(bytes) != 33 {
+	if len(bytes) != TurnkeyECDSAPublicKeyBytes {
 		return nil, fmt.Errorf("expected a 33-bytes-long public key (compressed). Got %d bytes", len(bytes))
 	}
 
@@ -99,7 +103,7 @@ func DecodeTurnkeyPublicECDSAKey(encodedPublicKey string, scheme signatureScheme
 
 		pubkey, err := dcrec.ParsePubKey(bytes)
 		if err != nil {
-			return nil, fmt.Errorf("cannot parse bytes into secp256k1 public key")
+			return nil, errors.New("cannot parse bytes into secp256k1 public key")
 		}
 
 		x = pubkey.X()

pkg/encryptionkey/encryptionkey.go

@@ -4,7 +4,6 @@ package encryptionkey
 import (
 	"encoding/hex"
 	"encoding/json"
-	"fmt"
 	"os"
 
 	"github.com/cloudflare/circl/hpke"
@@ -39,19 +38,19 @@ type Key struct {
 // New generates a new Turnkey encryption key.
 func New(userID string, organizationID string) (*Key, error) {
 	if userID == "" {
-		return nil, fmt.Errorf("please supply a valid User UUID")
+		return nil, errors.New("please supply a valid User UUID")
 	}
 
 	if _, err := uuid.Parse(userID); err != nil {
-		return nil, fmt.Errorf("failed to parse user ID")
+		return nil, errors.New("failed to parse user ID")
 	}
 
 	if organizationID == "" {
-		return nil, fmt.Errorf("please supply a valid Organization UUID")
+		return nil, errors.New("please supply a valid Organization UUID")
 	}
 
 	if _, err := uuid.Parse(organizationID); err != nil {
-		return nil, fmt.Errorf("failed to parse organization ID")
+		return nil, errors.New("failed to parse organization ID")
 	}
 
 	_, privateKey, err := KemID.Scheme().GenerateKeyPair()

pkg/store/local/local.go

@@ -26,6 +26,8 @@ const (
 	publicKeyExtension          = "public"
 	privateKeyExtension         = "private"
 	metadataExtension           = "meta"
+	fileOwnerRWGroupRAllR       = 0o0644
+	fileOwnerRW                 = 0o0600
 )
 
 // Store defines an api key Store using the local filesystem.
@@ -210,7 +212,7 @@ func (s *Store[T, M]) Store(name string, keypair common.IKey[M]) error {
 		return errors.Errorf("a keypair named %q already exists; exiting", name)
 	}
 
-	if err = createKeyFile(s.PublicKeyFile(name), keypair.GetPublicKey(), 0o0644); err != nil {
+	if err = createKeyFile(s.PublicKeyFile(name), keypair.GetPublicKey(), fileOwnerRWGroupRAllR); err != nil {
 		return errors.Wrap(err, "failed to store public key to file")
 	}
 
@@ -219,11 +221,11 @@ func (s *Store[T, M]) Store(name string, keypair common.IKey[M]) error {
 		privateKeyData = fmt.Sprintf("%s:%s", privateKeyData, curve)
 	}
 
-	if err = createKeyFile(s.PrivateKeyFile(name), privateKeyData, 0o0600); err != nil {
+	if err = createKeyFile(s.PrivateKeyFile(name), privateKeyData, fileOwnerRW); err != nil {
 		return errors.Wrap(err, "failed to store private key to file")
 	}
 
-	if err = s.createMetadataFile(s.MetadataFile(name), keypair.GetMetadata(), 0o0600); err != nil {
+	if err = s.createMetadataFile(s.MetadataFile(name), keypair.GetMetadata(), fileOwnerRW); err != nil {
 		return errors.Wrap(err, "failed to store key metadata")
 	}
 

pkg/store/local/local_test.go

@@ -14,11 +14,7 @@ import (
 
 // MacOSX has $HOME set by default.
 func TestGetKeyDirPathMacOSX(t *testing.T) {
-	require.NoError(t, os.Setenv("HOME", "/home/dir"))
-
-	defer func() {
-		require.NoError(t, os.Unsetenv("HOME"))
-	}()
+	t.Setenv("HOME", "/home/dir")
 
 	// Need to unset this explicitly: the test runner has this set by default!
 	originalValue := os.Getenv("XDG_CONFIG_HOME")
@@ -36,17 +32,8 @@ func TestGetKeyDirPathMacOSX(t *testing.T) {
 // On UNIX, we expect XDG_CONFIG_HOME to be set.
 // If it's not set, we're back to a MacOSX-like system.
 func TestGetKeyDirPathUnix(t *testing.T) {
-	require.NoError(t, os.Setenv("XDG_CONFIG_HOME", "/special/dir"))
-
-	defer func() {
-		require.NoError(t, os.Unsetenv("XDG_CONFIG_HOME"))
-	}()
-
-	require.NoError(t, os.Setenv("HOME", "/home/dir"))
-
-	defer func() {
-		require.NoError(t, os.Unsetenv("HOME"))
-	}()
+	t.Setenv("XDG_CONFIG_HOME", "/special/dir")
+	t.Setenv("HOME", "/home/dir")
 
 	assert.Equal(t, "/special/dir/turnkey/keys", local.DefaultAPIKeysDir())
 	assert.Equal(t, "/special/dir/turnkey/encryption-keys", local.DefaultEncryptionKeysDir())