Fix export signature verification #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkmin
approved these changes
May 9, 2024
| if (signedData === null || signedData.length !== 2) { | ||
| throw new Error(`unable to find signed data in bundle: ${bundle}`); | ||
| } | ||
| const signedDataBytes = new TextEncoder().encode(signedData[1] + "}"); |
There was a problem hiding this comment.
could add the same comments from export/index.template.html, but totally optional
|
Closing this PR, we've decided to fix this at the enclave level instead. The idea: return the actual signed bytes. That way there's no funny regex/parsing business that needs to happen, we can just grab this from the bundle and call verifySignature without further ado. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft to retrieve the actual signed bytes from the bundle.