Template quorum public key via k8s init containers, de-duplicate preprod and prod index files #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rod and prod index files
andrewkmin
reviewed
May 9, 2024
r-n-o
force-pushed
the
rno/reunite-prod-and-preprod
branch
from
5cfd0c6 to
e5f7d0f
Compare
|
|
||
| # Health endpoint for k8s | ||
| location = /health { | ||
| location = /health { |
There was a problem hiding this comment.
future improvement: lets move this endpoint elsewhere!
There was a problem hiding this comment.
Where do you think we should move it? Another port?
There was a problem hiding this comment.
Another port?
Yeah probably. and/or find some sort of metrics plugin
james-callahan
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.