Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harden uint8arrayFromHexString #30

Merged
merged 2 commits into from
Mar 29, 2024
Merged

Harden uint8arrayFromHexString #30

merged 2 commits into from
Mar 29, 2024

Conversation

r-n-o
Copy link
Collaborator

@r-n-o r-n-o commented Mar 27, 2024

Pretty straightforward: this change adds some validation to the argument passed to uint8arrayFromHexString and errors explicitly if it's bad (not a string, or an empty string, or a non-hex string)

@r-n-o r-n-o requested review from oliviathet and timurnkey March 27, 2024 22:13
timurnkey
timurnkey reviewed Mar 28, 2024
View reviewed changes
auth/index.html Outdated Show resolved Hide resolved
@r-n-o r-n-o merged commit b6361ef into main Mar 29, 2024
5 checks passed
@r-n-o r-n-o deleted the rno/uint8arrayFromHexString branch March 29, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timurnkey timurnkey timurnkey approved these changes

@oliviathet oliviathet Awaiting requested review from oliviathet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r-n-o @timurnkey