Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sha512 ESM #29

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Sha512 ESM #29

merged 2 commits into from
Mar 15, 2024

Conversation

oliviathet
Copy link
Contributor

Need to import sha512 for ed.getPublicKey and use sync instead of async method to get public key. Do not pass publicKey param to onInjectKeyBundle and remove the public key HTML elements used for testing.

@oliviathet oliviathet requested review from r-n-o and timurnkey March 15, 2024 17:28
@oliviathet oliviathet mentioned this pull request Mar 15, 2024
Merged
@oliviathet oliviathet merged commit 9688dc7 into main Mar 15, 2024
5 checks passed
@oliviathet oliviathet deleted the olivia/sha512-esm branch March 15, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timurnkey timurnkey timurnkey approved these changes

@r-n-o r-n-o Awaiting requested review from r-n-o

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliviathet @timurnkey