Add base58check decoding to recovery iframe #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emostov
reviewed
Nov 20, 2023
.nvmrc
Outdated
emostov
reviewed
Nov 20, 2023
emostov
reviewed
Nov 20, 2023
emostov
reviewed
Nov 20, 2023
| // Assuming random bytes in our bundle and a bundle length of 33 (public key, compressed) + 48 (encrypted cred) = 81 bytes. | ||
| // The odds of a byte being in the overlap set between base58 and base64url is 58/64=0.90625. | ||
| // Which means the odds of a 81 bytes string being in the overlap character set for its entire length is... | ||
| // ... 0.90625^81 = 0.0003444209703 |
emostov
approved these changes
Nov 20, 2023
|
Readability updates look great 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds base58check decoding. For now I've left base64url decoding in place, but we should be able to get rid of it once we release base58check recovery codes.
The nice thing about recovery codes is that they auto-expire after 30mins. So as soon as we switch to base58check codes, clock starts ticking, and we're good to delete the awkward branching after just 30mins (although, practically we'll wait a few hours at least!)