Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add export files #10

Merged
merged 4 commits into from
Oct 27, 2023
Merged

Add export files #10

merged 4 commits into from
Oct 27, 2023

Conversation

oliviathet
Copy link
Contributor

  • Adds all the export files in the export folder
  • Updates ci.yml GA workflow to include export
  • Updates README

TODO:
In future PRs, DRY up the shared styling and JS code between recovery and export :)

@oliviathet oliviathet requested a review from r-n-o October 27, 2023 16:25
@socket-security
Copy link

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
jest-environment-jsdom 29.7.0 None +10 263 kB simenb
@babel/preset-env 7.23.2 None +16 5.63 MB nicolo-ribaudo
@babel/core 7.23.2 None +5 3.98 MB nicolo-ribaudo
@testing-library/jest-dom 6.1.4 None +69 7.08 MB testing-library-bot

Copy link
Collaborator

@r-n-o r-n-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 🧙‍♀️ 💯

Comment on lines +13 to +15
strategy:
matrix:
directory: ["recovery", "export"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fancy!

README.md Outdated

# Running tests
This page is hosted on Github pages at https://tkhq.github.io/recovery/recovery
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update this to be the tkhqlabs.xyz links? Although...we can leave both links, why not.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep! Just realized this and updated in latest commit

README.md Outdated

Clone the repo:
```sh
git clone [email protected]:tkhq/recovery.git
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's update this to tkhq/frames

@oliviathet oliviathet merged commit 04578aa into main Oct 27, 2023
3 checks passed
@oliviathet oliviathet deleted the olivia/export branch October 27, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants