Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Quickstart Guide to use Examples from the Javascript SDK and add more context to examples #75
Migrate Quickstart Guide to use Examples from the Javascript SDK and add more context to examples #75
Changes from 5 commits
1771a8b
afb0f0e
dc4568d
5768609
fe8b435
0efd2fa
ea26ca8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should create the account in here to simplify onboarding? That way there's a single activity rather than 2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So my thought on this is that there's already confusion with the distinction between
wallets
andaccounts
and you can clear up some of that confusion to someone reading this guide by explicitly creating the resources in separate steps. I think in general it's a good pattern for quickstart guides to avoid creating multiple resources in a single step if there's a way to create them individually. I'd prefer leaving this as is, with the note underneath:Note: If desired, you can also create
accounts
in the same API call where you create thewallet
by passing in the account derivation paths as parameters to thecreateWallet
call.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the context of a "quick" start there are competing priorities: time to value is very important because typically people want to run through this as quick as possible. The other priority is clarity.
In this case it's probably fine to leave things the way you have it if you think it's clearer. But it's "one more thing" to copy/paste; that's the trade-off.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this needs to be replaced with code to create an unsigned transaction