Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug loading a watcher #36

Open
tjvr opened this issue Dec 20, 2016 · 2 comments
Open

Bug loading a watcher #36

tjvr opened this issue Dec 20, 2016 · 2 comments

Comments

@tjvr
Copy link
Owner

tjvr commented Dec 20, 2016

Found via scratch-corpus, loading Variable Names.sb2:

/usr/local/lib/python2.7/site-packages/kurt-2.0.7-py2.7.egg/kurt/__init__.pyc in value(self)
    951         """
    952         if self.kind == 'variable':
--> 953             return self.target.variables[self.block.args[0]]
    954         elif self.kind == 'list':
    955             return self.target.lists[self.block.args[0]]

KeyError: u'\u062b\u0645 \u0646\u0641\u0633 \u0633\u0642\u0637\u062a \u0648\u0628\u0627\u0644\u062a\u062d\u062f\u064a\u062f\u060c'

Looks like the variable name in the watcher is being split on commas for some reason! https://github.com/tjvr/kurt/blob/master/kurt/scratch20/__init__.py#L240-L241 I have no idea why I did this.

@nathan
Copy link

nathan commented Dec 22, 2016

I have no idea why I did this.

The senseVideoMotion watcher used to do this. (https://github.com/LLK/scratch-flash-common/commit/05ead51dec0c42f599bba049949ef1b38ed53915)

@tjvr
Copy link
Owner Author

tjvr commented Jan 9, 2017

@nathan Thank you so much! I can safely remove that then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants