Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
The CVE-2021-25943 security is now 1 year old and raises npm audit issues.
So, I applied the following recommandation:
#159 (comment)
with units tests into this pull request.
Nothing else has been changed. The npm test is still 100%:
`
[email protected] test
lab -c -l -t 100 -a code
..................................................
..................................................
..................................................
...............
165 tests complete
Test duration: 58 ms
Assertions count: 608 (verbosity: 3.68)
Coverage: 100.00%
Can you please accept this PR and publish an npm package accordingly ?
Note that I changed the implementation after review with my team, I silently ignore set with forbidden keys like in https://github.com/tjmehta/keypather/pull/43/files instead of throwing an error.
Test have been updated accordingly.