Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVE 2021 25943 fix #161

Closed
wants to merge 2 commits into from
Closed

CVE 2021 25943 fix #161

wants to merge 2 commits into from

Conversation

wid
Copy link

@wid wid commented Jan 5, 2022

Hi,

The CVE-2021-25943 security is now 1 year old and raises npm audit issues.

So, I applied the following recommandation:

#159 (comment)

with units tests into this pull request.

Nothing else has been changed. The npm test is still 100%:
`

[email protected] test
lab -c -l -t 100 -a code
..................................................
..................................................
..................................................
...............
165 tests complete
Test duration: 58 ms
Assertions count: 608 (verbosity: 3.68)
Coverage: 100.00%
Can you please accept this PR and publish an npm package accordingly ?

@wid
Copy link
Author

wid commented Jan 6, 2022

Please note that I throw an error when trying to set forbidden keys.
This is an explicit way of telling the downstream user should really be sure of overriding forbidden keys.

@wid wid force-pushed the CVE-2021-25943-fix branch from c12cbd2 to 0a8178a Compare January 6, 2022 10:06
@wid wid closed this Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant