Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable parsing of answers without question for mDNS #15

Closed
wants to merge 8 commits into from
Closed

Enable parsing of answers without question for mDNS #15

wants to merge 8 commits into from

Conversation

kmpm
Copy link

@kmpm kmpm commented Sep 25, 2014

Implements first part of issue #1.
Tests and closes #14

Implements first part of issue #1.
Tests and closes #14
@kmpm
Copy link
Author

kmpm commented Sep 25, 2014

Still can't write though...

Part 2 of issue #1.
Test packet generated by 2 chromecast devices
Still some issues when writing so roundtrip
does not work.
v0.1.0. + TLSA. Performance++ EDNS++. Fixes: EDNS/NAPTR/TXT. += PRs #2 and #3 from @rakoo

- Added TLSA support
- Fixed EDNS & NAPTR support + deprecates some EDNS fields on Packet
- Now includes support for forwarding EDNS responses (Packet.edns)
- Added many TODOs with suggested improvements
- Added many links to GH issues and RFCs
- Cleaned up code a bit to better please linters
- Added deprecation notices (see parseOpt)
- Handle unhandled RRs on writing packet instead of throwing exception.
- edns/opt should use BufferCursor.copy (Fixes #11)
- Updated `package.json` to include all authors
- Merged tj's `master` branch to add License info
- Updated README to include history of changes
@taoeffect
Copy link
Collaborator

@kmpm Is this still relevant given recently merged #7?

taoeffect and others added 5 commits October 5, 2014 16:40
Implements first part of issue #1.
Tests and closes #14
Part 2 of issue #1.
Test packet generated by 2 chromecast devices
Still some issues when writing so roundtrip
does not work.
@kmpm
Copy link
Author

kmpm commented Oct 6, 2014

It's relevant IF you wan't to support mdns/zeroconf, but I have to tidy up the pull-request.
Probably easiest to close this and make a new one...
What you are lacking today is mainly support for multiple questions and unfortunately for round trip testing utf8.

@kmpm kmpm closed this Oct 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bad Argument exception while parsing some mDNS packets.
2 participants